eclipse-openj9 / openj9

Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.
Other
3.28k stars 721 forks source link

Lots of files and directories left on Windows machines in User's Home dir #3600

Open AdamBrousseau opened 5 years ago

AdamBrousseau commented 5 years ago

Not sure if these are from compiles or tests or both. Likely multiple issues here. I guess more accurately, this is the Jenkins RemoteFS dir. The home dir would be cygwin /home/jenkins/ since we connect to these machines using cygwin-ssh.

C:\users\jenkins
files:
{028D07BC-8B92-4B73-8B30-F78F6EBCA625}
tmp4002297857010390153.lock
folders:
openj9tr_resources7151118105708709363
resource-3001439739939246237

@acrowthe pointed out this block of test code which is likely the culprit for the openj9tr_resources folders

AdamBrousseau commented 5 years ago

Not sure if I should make this issue more generic or open more issues or move to openjdk-tests repo. Constantly cleaning up /tmp is annoying. Here is an example of a tmp drive on an Aix box.

Count 189 each of

Count 17 of directories

Luckily these files/dirs do not consume space. However, there were also a couple cores which appear to be coming from some tests. I saved the javacore*txt files if anyone is interested.

smlambert commented 5 years ago

Those are 'likely' functional tests that are leaving detritus, which live in openj9 repo, so not appropriate as an openjdk-tests issue.

Someone with spare time could work on looking through functional tests that create extra files and junk and clean them up (we can mark this as good beginners issue).

Not condoning this as a fix, but why is /tmp cleanup on machines not automated, to avoid annoyance? Assuming its annoying because its being done manually? Going to assume you'd want to do that whether core issue fixed or not, as there may be on-going future reasons to want to keep /tmp clean.

AdamBrousseau commented 5 years ago

I have a cleanup job that deletes the Jenkins workspaces, in the event one of them hard fails before the "finally-cleanWs". I'll add tmp cleanup as well for the patterns listed in my previous comment, although as you say, it is not the correct solution.