search

eclipse-openj9 / openj9

Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.
Other
3.28k stars 721 forks source link

com.ibm.j9ddr.corereaders.tdump.zebedee.util.Template references nonexistent files #5927

Open jsoref opened 5 years ago

jsoref commented 5 years ago

Split from https://github.com/eclipse/openj9/pull/5909#discussion_r288322131

While there are links to templatedtd.dtd and templatedtd.html: https://github.com/eclipse/openj9/blob/3ddd56b705757e978be121a87c932e3d37c95206/debugtools/DDR_VM/src/com/ibm/j9ddr/corereaders/tdump/zebedee/util/Template.java#L42-L45

The only related file in this directory is template.dtd.

There's no code history to speak of, and no obvious references.

The only instance of the filename templatedtd.html per google is the zebedee/util/Template.java file itself: https://www.google.com/search?q=%22templatedtd.html%22

Is there anyone who might know what this is talking about? Offhand, it feels like two files were lost in open-sourcing: templatedtd.html and oldtemplate.html: https://github.com/eclipse/openj9/blob/3ddd56b705757e978be121a87c932e3d37c95206/debugtools/DDR_VM/src/com/ibm/j9ddr/corereaders/tdump/zebedee/util/template.dtd#L14-L16 (That the author is the anonymous I doesn't help matters.)

pshipton commented 5 years ago

I looked back in the IBM history before OpenJ9 was contributed to open source, but couldn't find the file there either. Whoever wrote the comment is probably gone, I figure the easiest thing is to leave it alone in case it means something to somebody.

@fjeremic any thoughts?

fjeremic commented 5 years ago

Given it's in the tdump directory we'll likely need to go back about 15 years to see where this originated. I'll take a look by tomorrow to see if I can find the original author and intention.

fjeremic commented 5 years ago

I can't seem to find the origin. I've gone as far back as 2007 and it's still around. Not sure how much we can do about this or if it even matters.