Use socket API from portlib for JITaaS

eclipse-openj9 / openj9

Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.

Other

3.24k stars 714 forks source link

Use socket API from portlib for JITaaS #6131

Open mpirvu opened 5 years ago

mpirvu commented 5 years ago

Currently, the network communication layer in JITaaS is implemented using unix socket API. For portability we should replace that API with the one offered by the portlib and implemented in j9sock.c, unless it adds too much overhead (I doubt it)

pdbain-ibm commented 5 years ago

Currently, this is used only by the Harmony JDWP implementation (which I believe is now completely supplanted by the OpenJDK implementation). There is consideration now being given to removing this API. I suggest discussing this with @pshipton.

pshipton commented 5 years ago

Indeed, we were hoping to remove the obsolete j9sock APIs from the OpenJ9 port library. As I understand it, at least some of the j9sock implementations are stale, which I think means not suitable for IPv6. A better approach is to implement a omrsock port library layer at the OMR project, containing what is needed to support JITaas. The parts of j9sock that are still relevant can be copied to omrsock.