search

eclipse-openj9 / openj9

Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.
Other
3.27k stars 721 forks source link

PR build with depends doesn't show the correct sha #9537

Open pshipton opened 4 years ago

pshipton commented 4 years ago

@AdamBrousseau PR testing with depends eclipse/omr#master shows an incorrect sha. Looking at the top level build https://ci.eclipse.org/openj9/job/PullRequest-OpenJ9/3544/ it shows OMR: cd259de, which was the eclipse/openj9-omr openj9 branch head, and not what was actually tested. If you dig into one of the builds https://ci.eclipse.org/openj9/job/Build_JDK8_s390x_linux_Personal/626, you can see it actually built from HEAD is now at b8634d51d, which was the head of the master branch at the time.

pshipton commented 4 years ago

I'm also wondering if all the builds are guaranteed to use the same OMR sha in this case, or would they get master at the time each build ran.

AdamBrousseau commented 4 years ago

Yes this has always been a caveat of the PR depends. And yes, if you're kicking several builds and they end up staggering you could end up testing a different Sha in each. This is because the depends logic is down in the compile job instead of at the top level. It could be refactored but I'm not sure how much work that would be. I'd have to take a look.