search

eclipse-osgi-technology / jakartarest-osgi

Glassfish Jersey based implementation of the OSGi Jakarta RESTful Web Services Whiteboard specification
https://projects.eclipse.org/projects/technology.osgi-technology
Eclipse Public License 2.0
3 stars 5 forks source link

Impl #44 - Add CRaC support #45

Open fipro78 opened 4 months ago

fipro78 commented 4 months ago

This PR adds CRaC support to the jetty bundle by using the org.crac API.

It adapts

@AntonKozlov Could you also have a look and provide some comment, if my assumption that the usage of org.crac API is without a risk here?

AntonKozlov commented 4 months ago

Hi @fipro78,

LGTM.

The resource is hard-referenced, the code for jetty is aligned with our examples (I'm not an expert there), so overall looks good.

Thank you!

fipro78 commented 1 month ago

As discussed with @tjwatson and @stbischof I updated the PR to make the org.crac API optional at runtime.

I successfully tested:

  1. Runtime without org.crac
  2. Runtime with org.crac on a system that has no CRIU support
  3. Runtime with org.crac on a system with CRIU support

All cases work as expected. The failures in the checks seem to be not related to my work.