search

eclipse-packaging / packages

Eclipse IDE product definitions.
Eclipse Public License 2.0
4 stars 11 forks source link

Update require Java 21 #130

Closed merks closed 5 months ago

merks commented 5 months ago

@jonahgraham

I will coordinate the necessary changes with the JustJ changes.

Note that the first 2024-06 M1 content build using the restructured infrastructure was successful:

https://download.eclipse.org/justj/?file=technology/epp/staging

BTW, I've never seen this before:

image

I assume this should be updated to 21 too.

jonahgraham commented 5 months ago

<vmArgs>

Yes, this needs updating to fail early if wrong Eclipse is present.

<vm> section I assume so - they were updated for all previous updates and correspond to this part of the UI:

image

However I don't know if there is a purpose for the build. The Platform's product file does not have this info. PDE uses this section to populate the the launch configuration, so keeping it in doesn't seem like a bad idea:

image

For reasons of probable simple oversight DSL still has Java 11 in that section. It should probably be synchronized too:

https://github.com/eclipse-packaging/packages/blob/42922409eb441e9006db069e817a5a134c74e2fe/packages/org.eclipse.epp.package.dsl.product/epp.product#L59-L61

merks commented 5 months ago

The latest staging build includes all the support for Java 21:

https://download.eclipse.org/justj/?file=technology/epp/staging