Allow all product requirements to be updated

[merks]

• Change all feature includes in products to be installMode="root".
• Add a requires/import to the corresponding product feature for each such modified feature include.
• Remove all references to org.eclipse.equinox.p2.user.ui and org.eclipse.help because these are included by org.eclipse.platform anyway.
• Change any non-epp plug-in include in a feature to a requires/import import, i.e., in the jee feature.xml.

https://github.com/eclipse-packaging/packages/issues/133

[merks]

As you can see in the linked issue, I've tested this locally, so I'm 99.9% sure this is all pure goodness.

With this approach we can be sure that if there is some CVE or severe bug in the future for which there is an update from the project(s) it can be installed/updated without creating a new SimRel repo and without creating new EPP packages.

[jonahgraham]

This seems fine to me to make platform root, the product file has long mirrored what is in https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/b6e8ff5b66f16d772c0fef5d05e2b1cee82ae2a0/eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/platform.product#L181-L182 which doesn't use root - but of course for platform they release new products at the same time as those new features so the problem doesn't exist there.

Is it ok to remove the p2 ui though? Is it guaranteed to be installed? Perhaps it is equally redundant in the platform's version.

---

Minor de-duplication question.

Can:

   <!-- This ensures this feature cannot be uninstalled. It is installed with installMode="root" in the product --> 
   <requires>
      <import feature="org.eclipse.platform" version="4.0.0" match="compatible"/>
   </requires>

be put in https://github.com/eclipse-packaging/packages/blob/master/packages/org.eclipse.epp.package.common.feature/feature.xml

[merks]

These two things are required by org.eclipse.platform:

Granted the p2 thing is optional greedy but given it's visible in the release train, it's always installed, and making no mention of it elsewhere ensures that it can't be uninstalled because it doesn't appear in the roots. But I could add an requires/import too. Do you think that's best?

---

Yes, I could move the feature requires to the common feature. It's just that some of the features has includes of org.eclipse.platform so I tended in that direction. If you wish, and I think it's a good idea, we should move this to the common feature. Okay?

[jonahgraham]

Do you think that's best?

Sorry - don't know what is best. With my uncertainty I will err on the side of explicitly having it explicitly listed.

---

If you wish, and I think it's a good idea, we should move this to the common feature. Okay?

Yes +1