eclipse-packaging / packages

Eclipse IDE product definitions.
Eclipse Public License 2.0
4 stars 12 forks source link

The eclipse-sign-jar profile seems overused #152

Closed merks closed 5 months ago

merks commented 5 months ago

@jonahgraham

I was looking at this item:

Note that you can always use this URL for the above instruction:

https://ci.eclipse.org/packaging/job/epp/job/master/lastBuild/consoleText

Looking for warnings, I see it's quite clean but I see these:

[2024-05-02T07:37:44.103Z] [WARNING] The requested profile "eclipse-sign-jar" could not be activated because it does not exist.

I think that's because we use that profile in all the maven builds but I think we only need/should specify it for the first build which build features and not for the subsequent builds:

image

Does that make sense?

jonahgraham commented 5 months ago

Yes it does - I had actually just been creating a PR on that, I'll link it here.

jonahgraham commented 5 months ago

Thanks to this last step and all the work you did during M1, the build is now warning free. The checklist has been updated to say Check that there are no warnings in the console output.

merks commented 5 months ago

I love warning free builds!