epp-makeVisible CI job says "successful" even on failure

[jonahgraham]

Due to an error when I did the gerrit -> github transition a couple of the files were misnamed in https://download.eclipse.org/technology/epp/packages/2023-06/

However when the script ran to make visible it said success (see log below).

The false positive looks like a side effect of the move to JIPPs and running stuff in SSH so the set -e no longer fails the sub-script.

00:00:01.034 [epp-makeVisible] $ /bin/bash /tmp/jenkins7448621540531384166.sh
00:00:01.045 + ECHO=
00:00:01.045 + REPO=/home/data/httpd/download.eclipse.org/technology/epp/packages/2023-06/
00:00:01.045 + printf '\n\t[INFO] Working on: trainname: 2023-06 checkpoint: M1\n'
00:00:01.045 
00:00:01.045    [INFO] Working on: trainname: 2023-06 checkpoint: M1
00:00:01.045 + '[' M1 == RC2 ']'
00:00:01.045 + ssh genie.packaging@projects-storage.eclipse.org /bin/bash
00:00:02.983 cp: cannot stat '/home/data/httpd/download.eclipse.org/technology/epp/packages/2023-06/compositeArtifactsM1.xml': No such file or directory
00:00:02.983 cp: cannot stat '/home/data/httpd/download.eclipse.org/technology/epp/packages/2023-06/compositeContentM1.xml': No such file or directory
00:00:02.983 rm: cannot remove '/home/data/httpd/download.eclipse.org/technology/epp/packages/2023-06/compositeContent.jar': No such file or directory
00:00:02.983 rm: cannot remove '/home/data/httpd/download.eclipse.org/technology/epp/packages/2023-06/compositeArtifacts.jar': No such file or directory
00:00:02.983 rm: cannot remove '/home/data/httpd/download.eclipse.org/technology/epp/packages/2023-06/p2.index': No such file or directory
00:00:02.993 $ ssh-agent -k
00:00:02.996 unset SSH_AUTH_SOCK;
00:00:02.996 unset SSH_AGENT_PID;
00:00:02.996 echo Agent pid 55 killed;
00:00:03.000 [ssh-agent] Stopped.
00:00:03.100 Email was triggered for: Always
00:00:03.100 Sending email for trigger: Always
00:00:03.107 Sending email to: frederic.gurr@eclipse-foundation.org mknauer@eclipsesource.com jonah@kichwacoders.com
00:00:03.273 Finished: SUCCESS

[jonahgraham]

I haven't fixed the script yet - but it was actually successful for M2.

[merks]

I was just looking at this to make sure that my M2a thing didn't mess up...

[jonahgraham]

I have fixed the script - but I can't easily test it so I will monitor closely in ~10 minutes when I expect it to run.

[jonahgraham]

Turning on all the set -x/e/u exposed a minor issue in the script, for 2023-06 M3 we got a false failure. i.e. the make visible worked, but one of the cleanup steps falsely reported as failing.

I have fixed that now and am closing this issue.