eclipse-packaging / packages

Eclipse IDE product definitions.
Eclipse Public License 2.0
4 stars 11 forks source link

Wrong splash screen, without "IDE" for 2024-06 #178

Closed howlger closed 1 month ago

howlger commented 1 month ago

For the 2024-06 release the wrong splash screen is included: the splash screen without "IDE" is for the Eclipse project, but the IDE packages should have the splash screen with "IDE".

See https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3963#note_2342954

merks commented 1 month ago

When I asked here and followed the instructions, it just wasn't clear which image I should use:

https://github.com/eclipse-packaging/packages/issues/111#issuecomment-2032422786

In the future it would be good if such a resolved issue included specifically and clearly final images. I did end up hunting through the platform's images to find things I needed and to have an issue like this opened after the final RC2 build has started is kind of a bit frustrating.

jonahgraham commented 1 month ago

I didn't notice that the IDE part was missing on the splash screen - I only noted in my smoke tests that it was indeed updated to 2024-06 splash.

As we have the correct splash screen available already (here?) we should change it before completing RC2 build today.

I will be in front of my computer in a couple of hours to do that unless someone gets there first.

merks commented 1 month ago

@jonahgraham

I think we can just merge this immediately and start another build immediately, right?

merks commented 1 month ago

A new build has started:

https://ci.eclipse.org/packaging/job/epp/job/master/82/

jonahgraham commented 1 month ago

I think we can just merge this immediately and start another build immediately, right?

Yes :-) and thanks for handling this!

merks commented 1 month ago

While we are on this topic, where will I find images for 2024-09, 2024-12, and so on?

jonahgraham commented 1 month ago

https://github.com/eclipse-packaging/packages/blob/17f8c753c9f50b4b13e8030d0d19a70207227c94/packages/org.eclipse.epp.package.common/splash/INSTRUCTIONS.md#L14

or as someone has nicely put them here as an alternative https://github.com/eclipse-platform/eclipse.platform/tree/master/platform/org.eclipse.platform/splashscreens2024

merks commented 1 month ago

I've created a bookmark. 👍

jonahgraham commented 1 month ago

In case you lose it - that splash instructions.md is linked from this item in the releasing checklist:

https://github.com/eclipse-packaging/packages/blob/17f8c753c9f50b4b13e8030d0d19a70207227c94/RELEASING.md#L15

(which I just realized has a mistake at the end which I have updated in #180

jonahgraham commented 1 month ago

I think we are done here - the splash screen looks correct now.

Thanks @howlger for taking the time to file the report! Thanks @merks for rolling out the fix quickly!

merks commented 1 month ago

Good teamwork all around! 🥇