search

eclipse-packaging / packages

Eclipse IDE product definitions.
Eclipse Public License 2.0
4 stars 11 forks source link

Update Eclipse.icns to match Apple UI Guideline #77

Closed BeckerWdf closed 10 months ago

BeckerWdf commented 10 months ago

Fixes: https://github.com/eclipse-platform/eclipse.platform.ui/issues/1247

BeckerWdf commented 10 months ago

@jonahgraham: Can you pls. review?

jonahgraham commented 10 months ago

@BeckerWdf thanks for this fix.

As this applies this releasing.md step you have saved me some time by applying it yourself. Thank you!

https://github.com/eclipse-packaging/packages/blob/278d8d4c85c90c923ce75996f2136ba5720aec30/RELEASING.md#L49

jonahgraham commented 10 months ago

In a few hours a new build (still called M2 because I haven't done the other steps of #79 yet) will be published to https://download.eclipse.org/technology/epp/staging/ if you can test it out to make sure it looks as expected on mac.

BeckerWdf commented 10 months ago

In a few hours a new build (still called M2 because I haven't done the other steps of #79 yet) will be published to https://download.eclipse.org/technology/epp/staging/ if you can test it out to make sure it looks as expected on mac.

Sure. I can test that. Just ping me once it's available.

BeckerWdf commented 10 months ago

In a few hours a new build (still called M2 because I haven't done the other steps of #79 yet) will be published to https://download.eclipse.org/technology/epp/staging/ if you can test it out to make sure it looks as expected on mac.

Sure. I can test that. Just ping me once it's available.

I just tested with eclipse-committers-2023-12-M2-macosx-cocoa-aarch64.tar.gz. It looks good:

image
jonahgraham commented 10 months ago

Thanks for reporting back that it looks good.

BeckerWdf commented 9 months ago

just had a loot at it on the final 2023-12 EPPs. It is fixed.

jonahgraham commented 9 months ago

Thanks @BeckerWdf for fixing this and tracking it through all the way to release!