eclipse-paho / paho.mqtt.android

MQTT Android
Other
2.94k stars 890 forks source link

Sending corrupt SUBACK package, crashes the MQTT Client app and Google services, Google Play store. #214

Open sekamaneka opened 7 years ago

sekamaneka commented 7 years ago

Android 7.0. Newest 'MQTT Client' app from playstore. This affects multiple MQTT apps based on the paho.mqtt implementation.

Description of Bug:

  1. Try to connect with client to the server.
  2. Send a malformed package as SUBACK.
  3. Click on connect again.
  4. Wait for ANR (MQTT Client).
  5. Click on submit feedback.
  6. Tap on system info.
  7. Tap on View ANR trace.
  8. Wait for google services to ANR.
  9. Send feedback.
  10. Wait for google play store to ANR.

The google play services crash can't always be reproduced. The ANR crash in the MQTT Client app can be 100% reproduced in my environment.

Console Log output (if available):

A sample package in hex notation that produces the above mentioned crash is: 90 09 00 04 01

jpwsutton commented 7 years ago

Hi @swilso793, we don't manage any apps on the Google Play Store, I suggest that you contact the developers of the apps in question. If there is a reproducible issue with the Java and thus Android service with the handling of corrupt packets then we will definitely be able to resolve this, but without any kind of stack trace it's hard to look at this further. It could just be that the developers of the apps in question are not handling an exception correctly.