eclipse-pass / main

Catch all repository against which issues of general, cross cutting topics are logged.
Apache License 2.0
4 stars 8 forks source link

Springify Journal Loader #1037

Open rpoet-jh opened 3 months ago

rpoet-jh commented 3 months ago

What?

The pass-support/pass-journal-loader should be converted to a Spring Boot project. The other data loaders are already Spring Boot projects.

Why? To be consistent with the other data loaders, and to remove boiler plate code.

Acceptance Criteria pass-support/pass-journal-loader is Spring Boot.

jabrah commented 3 months ago

As a reminder, we can only accept changes through pull requests through GitHub. Please see our contribution guidelines for more information!

rpoet-jh commented 1 month ago

When journal loader is converted to a spring app, we should also enable loading app props from aws param store. See this PR for example of how it is done: https://github.com/eclipse-pass/pass-support/pull/126