eclipse-pass / main

Catch all repository against which issues of general, cross cutting topics are logged.

Apache License 2.0

4 stars 8 forks source link

404 produces Whitelabel Error Page with stacktrace #1062

Closed rpoet-jh closed 1 month ago

rpoet-jh commented 1 month ago

Environment

PROD

Date/time occurred

2024-10-09 10:30a

Description

Typing an invalid path on PASS produces the default Whitelabel Error Page with stacktrace.

Steps to Reproduce

Log into https://app.pass.jhu.edu/ In the browser address bar, type https://app.pass.jhu.edu/foobar You'll see the Whitelabel Error Page with stacktrace

Expected Results

A standard error page should be returned for invalid paths without stacktrace. Note that if the path has /app, then it is good, this is just an issue when /app is not in the path.

Actual Results

Default error page is returned which contains stacktrace which is not recommended.

Evidence

Estimated Severity

Major

rpoet-jh commented 1 month ago

server.error.whitelabel.enabled=false has been set in jhu stage and prod to disable whitelabel error page. Now error page looks like:

We should configure a more "user friendly" error page.

markpatton commented 1 month ago

When /app/ is in the path, then the error page is handled by pass-ui. Otherwise it is handled by pass-core and we can add whatever default error page we want.