search

eclipse-pass / main

Catch all repository against which issues of general, cross cutting topics are logged.
Apache License 2.0
4 stars 7 forks source link

Java release actions should not build snapshots #883

Open markpatton opened 5 months ago

markpatton commented 5 months ago

What?

On push of a snapshot version to main, Java repositories build a snapshot. Currently the release action also builds a snapshot, but this is not needed, because the release action commits a SNAPSHOT version to main. On release the snapshot version ends up getting built twice.

Why?

It is wasteful and makes the release actions take longer.

How?

This should be able to be done pretty easily by just removing the snapshot building steps from the release and pass-java-release workflows in the main repository. The other repositories use those workflows.

Acceptance Criteria

Successfully do a mock test release. Can edit the action to have have it not actually push to sonatype or make commits for the test.

Related Issues

markpatton commented 5 months ago

One problem with this approach is that the snapshot builds will likely trigger simultaneously. Depending on the timing, some of the builds are likely to fail because they depend on other builds in progress. Failures would leave the snapshot builds in an annoying state and require the builds be manually restarted.

The good thing about doing the snapshot builds in the release actions is that the snapshot builds are always in a good state. We may want to reconsider doing this ticket.