NIHMS packages created from End-to-end testing contains no journal metadata

htpvu commented 6 years ago

here is the metadata blob:

[
   {
      "id":"common",
      "data":{
         "title":"Electrogenerated chemiluminescence of Ru(bpy)32+ at a black phosphorus quantum dot modified electrode and its sensing application",
         "container-title":"The Analyst",
         "volume":"143",
         "issue":"1",
         "ISSN":"0003-2654,1364-5528",
         "abstract":"Strong anodic electrogenerated chemiluminescence (ECL) of Ru(bpy)32+ can be obtained under neutral conditions at a black phosphorus quantum dot (BPQD) modified electrode due to the catalytic effect of BPQDs. Dopamine exhibits an apparent inhibiting effect on the ECL signal, and as a result, can be sensitively detected.",
         "authors":[
            {
               "author":"Lei Zhang"
            },
            {
               "author":"KaiJin Tian"
            },
            {
               "author":"YongPing Dong",
               "orcid":"http://orcid.org/0000-0002-0455-9982"
            },
            {
               "author":"HouCheng Ding"
            },
            {
               "author":"ChengMing Wang"
            }
         ]
      }
   },
   {
      "id":"crossref",
      "data":{
         "doi":"10.1039/c7an01617d",
         "publisher":"Royal Society of Chemistry (RSC)",
         "journal-title-short":"Analyst"
      }
   }
]

htpvu commented 6 years ago

one of the files sent to NIHMS that failed.

nihms-native-2017-07_2018-06-20_20-06-25_d0ff66f3-f336-40c1-b8c1-57042c65057b.tar.gz

htpvu commented 6 years ago

more blob

[
   {
      "id":"JScholarship",
      "data":{
         "embargo":"NON-EXCLUSIVE LICENSE FOR USE OF MATERIALS This non-exclusive license defines the terms for the deposit of Materials in all formats into the digital repository of materials collected, preserved and made available through the Johns Hopkins Digital Repository, JScholarship. The Contributor hereby grants to Johns Hopkins a royalty free, non-exclusive worldwide license to use, re-use, display, distribute, transmit, publish, re-publish or copy the Materials, either digitally or in print, or in any other medium, now or hereafter known, for the purpose of including the Materials hereby licensed in the collection of materials in the Johns Hopkins Digital Repository for educational use worldwide. In some cases, access to content may be restricted according to provisions established in negotiation with the copyright holder. This license shall not authorize the commercial use of the Materials by Johns Hopkins or any other person or organization, but such Materials shall be restricted to non-profit educational use. Persons may apply for commercial use by contacting the copyright holder. Copyright and any other intellectual property right in or to the Materials shall not be transferred by this agreement and shall remain with the Contributor, or the Copyright holder if different from the Contributor. Other than this limited license, the Contributor or Copyright holder retains all rights, title, copyright and other interest in the images licensed. If the submission contains material for which the Contributor does not hold copyright, the Contributor represents that s/he has obtained the permission of the Copyright owner to grant Johns Hopkins the rights required by this license, and that such third-party owned material is clearly identified and acknowledged within the text or content of the submission. If the submission is based upon work that has been sponsored or supported by an agency or organization other than Johns Hopkins, the Contributor represents that s/he has fulfilled any right of review or other obligations required by such contract or agreement. Johns Hopkins will not make any alteration, other than as allowed by this license, to your submission. This agreement embodies the entire agreement of the parties. No modification of this agreement shall be of any effect unless it is made in writing and signed by all of the parties to the agreement.",
         "agreement-to-deposit":"true"
      }
   },
   {
      "id":"common",
      "data":{
         "title":"Late-life suicide prevention strategies: current status and future directions",
         "container-title":"Current Opinion in Psychology",
         "volume":"22",
         "ISSN":"2352-250X",
         "authors":[
            {
               "author":"Kim Van Orden"
            },
            {
               "author":"Charlene Deming"
            }
         ],
         "Embargo-end-date":"2018-06-30"
      }
   },
   {
      "id":"crossref",
      "data":{
         "doi":"10.1016/j.copsyc.2017.08.033",
         "publisher":"Elsevier BV",
         "journal-title-short":"Current Opinion in Psychology"
      }
   }
]

emetsger commented 6 years ago

@htpvu Ok, for testing purposes I have merged the two JSON documents to insure coverage across the different elements represented in each document, and have changed container-title to journal-title. This is the document (or minor variations of) that deposit services will be using in its ITs and UTs:

[
  {
    "id":"common",
    "data":{
      "title":"Electrogenerated chemiluminescence of Ru(bpy)32+ at a black phosphorus quantum dot modified electrode and its sensing application",
      "journal-title":"The Analyst",
      "volume":"143",
      "issue":"1",
      "ISSN":"0003-2654,1364-5528",
      "abstract":"Strong anodic electrogenerated chemiluminescence (ECL) of Ru(bpy)32+ can be obtained under neutral conditions at a black phosphorus quantum dot (BPQD) modified electrode due to the catalytic effect of BPQDs. Dopamine exhibits an apparent inhibiting effect on the ECL signal, and as a result, can be sensitively detected.",
      "authors":[
        {
          "author":"Lei Zhang"
        },
        {
          "author":"KaiJin Tian"
        },
        {
          "author":"YongPing Dong",
          "orcid":"http://orcid.org/0000-0002-0455-9982"
        },
        {
          "author":"HouCheng Ding"
        },
        {
          "author":"ChengMing Wang"
        }
      ],
      "Embargo-end-date":"2018-06-30"
    }
  },
  {
    "id":"crossref",
    "data":{
      "doi":"10.1039/c7an01617d",
      "publisher":"Royal Society of Chemistry (RSC)",
      "journal-title-short":"Analyst"
    }
  },
  {
    "id":"JScholarship",
    "data":{
      "embargo":"NON-EXCLUSIVE LICENSE FOR USE OF MATERIALS This non-exclusive license defines the terms for the deposit of Materials in all formats into the digital repository of materials collected, preserved and made available through the Johns Hopkins Digital Repository, JScholarship. The Contributor hereby grants to Johns Hopkins a royalty free, non-exclusive worldwide license to use, re-use, display, distribute, transmit, publish, re-publish or copy the Materials, either digitally or in print, or in any other medium, now or hereafter known, for the purpose of including the Materials hereby licensed in the collection of materials in the Johns Hopkins Digital Repository for educational use worldwide. In some cases, access to content may be restricted according to provisions established in negotiation with the copyright holder. This license shall not authorize the commercial use of the Materials by Johns Hopkins or any other person or organization, but such Materials shall be restricted to non-profit educational use. Persons may apply for commercial use by contacting the copyright holder. Copyright and any other intellectual property right in or to the Materials shall not be transferred by this agreement and shall remain with the Contributor, or the Copyright holder if different from the Contributor. Other than this limited license, the Contributor or Copyright holder retains all rights, title, copyright and other interest in the images licensed. If the submission contains material for which the Contributor does not hold copyright, the Contributor represents that s/he has obtained the permission of the Copyright owner to grant Johns Hopkins the rights required by this license, and that such third-party owned material is clearly identified and acknowledged within the text or content of the submission. If the submission is based upon work that has been sponsored or supported by an agency or organization other than Johns Hopkins, the Contributor represents that s/he has fulfilled any right of review or other obligations required by such contract or agreement. Johns Hopkins will not make any alteration, other than as allowed by this license, to your submission. This agreement embodies the entire agreement of the parties. No modification of this agreement shall be of any effect unless it is made in writing and signed by all of the parties to the agreement.",
      "agreement-to-deposit":"true"
    }
  }
]

htpvu commented 6 years ago

understood.

emetsger commented 6 years ago

⛔ = fixed value, or provided by the target repo ✅ = identified in the metadata blob ❌ = verified that we don’t need to capture this or include it in repo-specific metadata

NIH Metadata

Manuscript Metadata:

nihms id⛔ (provided by target)
isPublisherPdf⛔(effectively fixed, not provided by blob so defaults to false)
showPublisherPdf⛔(effectively fixed, not provided by blob so defaults to false)
manuscriptUrl⛔ (Not parsed from the Submission, unused)
manuscript title✅

Article Metadata:

embargo is ignored (for NIH)❌
doi✅

Journal Metadata

journal id❌
journal id type⛔ (fixed value)
publication type❓(not in the NIH metadata, defaults to null in serializer, and never set, so probably not needed)
issn ✅
journal title✅

Blob locations

Authors: “id”: “common” “data”: “authors” “author”

DOI: “id”: “crossref” “data”: “doi”

Journal Title: “id”:”common” “data”:”journal-title”

ISSN: “id”:”common” “data”:”ISSN”

Abstract: “id”:”common” “data”:”abstract”

Embargo: “id”:”common” “data”:”Embargo-end-date” (YYYY-MM-DD)

Ms Title: “id”:”common” “data”:”title”

eclipse-pass / pass-deposit-services