search

eclipse-pass / pass-deposit-services

Deposit Services are responsible for the transfer of custodial content and metadata from end users to repositories.
Apache License 2.0
1 stars 4 forks source link

Update docker images #288

Closed jabrah closed 2 years ago

jabrah commented 2 years ago

Tests fail

jabrah commented 2 years ago

It looks like these integration tests are failing because of mis-configured ports in the ftpserver Docker image. The server is trying to use servers not mapped in the IT setup.

The entrypoint in the Dockerfile tells pure-ftpd to use ports 30000 through 30100. The ITs in question are configured to map 30000 through 30010. I'm not exactly sure of all of the consequences, but the FTP server tries to use ports outside of the mapped range, so the requests fail. I tested restricting the ports in the Dockerfile to 30000 - 30010 and the tests (locally) passed.

From the local testing, it seems that we can fix the failing tests by either updating the Docker image to restrict the port range OR map the port range in the IT configuration. Adding to this, pass-docker:docker-compose is configured to map ports 30000:30010.

The change to the Dockerfile was made originally in order to allow more simultaneous client connections to the FTP server. However, I don't see an associated ticket, so I can't judge how important of a change this was.