search

eclipse-pass / pass-docker

Developer-focused PASS runtime, which provides PASS and all of its dependent services using docker-compose. Provides Docker images used for production deployment of PASS.
Apache License 2.0
0 stars 16 forks source link

Update demo data for deployment test support in pass-acceptance #369

Closed rpoet-jh closed 4 months ago

rpoet-jh commented 4 months ago

This PR changes some of the demo data to support this PR: https://github.com/eclipse-pass/pass-acceptance-testing/pull/17

Note this PR is branched off of 903-auth which is the pass auth consolidation ticket so this PR should be merged after the 903-auth PRs are merged.

Note this commit is the only change that will be in the PR once the 903-auth changes are merged: https://github.com/eclipse-pass/pass-docker/pull/369/commits/661e965c045141a041a7ef7c28a4d467dcc7b8a1

rpoet-jh commented 4 months ago

The only minor issue I can think of is that this looks like it changes some human readable names to markers that the acceptance tests will look for. But if this data is loaded in the demo, then the demo user may see this info that looks a bit confusing.

Yeah, I understand, but I wanted to make it clear which grant/funder data are being used for e2e tests so other devs don't change them. I tried to make the labels which are displayed on the UI readable (i.e. TEST_E2E_GRANT, TEST_E2E_AWD_NUM, etc.).

Also, like you said, these names do have be immutable so submissions on the grant can be found and cleaned up.