eclipse-pass / pass-ui

UI code base for PASS
Apache License 2.0
4 stars 16 forks source link

Ember UI barfs when there are no grants for a Submission #1021

Open emetsger opened 5 years ago

emetsger commented 5 years ago

This may be an issue with the policy service, not sure- I admit I haven't dug in to determine which -

Performing a submission where there are no grants for the submission results in the following:

Screen Shot 2019-08-19 at 9 54 10 AM

Even if the issue is with the policy service, probably the Ember UI should handle it more gracefully? Even with no grants, I should still be able to submit to the institutional repository.

As a note, this error condition is occurring with a local branch configured for Harvard, which can be found at https://github.com/emetsger/pass-docker, branch harvard-pass, commit 2c4735e71.

To replicate, check out that commit and:

Then login as the nih-user and attempt to perform a submission.

jrmartino commented 5 years ago

i saw this too, in the pass-docker setup

emetsger commented 5 years ago

It should also be noted that the policy service used by this branch/commit does not have https://github.com/OA-PASS/pass-policy-service/pull/17 applied.

jabrah commented 5 years ago

From the UI side, we can tie this into #922. We should make error handling a lot more robust in the Ember app

htpvu commented 5 years ago

@jabrah @jrmartino is this still an issue in the latest pass-docker?