search

eclipse-pass / pass-ui

UI code base for PASS
Apache License 2.0
4 stars 16 forks source link

Acceptance tests fail running on ember-dev #1110

Open markpatton opened 3 years ago

markpatton commented 3 years ago

To reproduce the problem run docker-compose up wait for it to start and then visit https://pass.local/app/tests

The unit tests pass, but the acceptance tests fail. The acceptance tests pass on the command line. There must be some configuration difference between the two methods of running tests.

jabrah commented 2 years ago

This may have something to do with some mirage specific ports not being exposed in the docker setup.

@jaredgalanis and I have been separately running ember test -s in parallel with the docker environment in order to run tests. This will expose a separate local test server at localhost:4200 (or whatever the command will display on the command line) and will run fine along side Docker because the acceptance tests all use mocked data, instead of running services.

Do you think this is an acceptable workflow, or should we investigate whether or not we can get the tests running directly out of the local docker instance?

jaredgalanis commented 2 years ago

For what it's worth, the test command @jabrah is describing is what CI was using to run the tests and it is why the test suite in pass-ui's CI has been passing.

To the extent we're exploring de-dockerizing pass-ui I would say let's not make changes to the ember tests that make them pass/operate well in the docker stack until we know what we're doing re dockerization.