eclipse-pass / pass-ui

UI code base for PASS
Apache License 2.0
4 stars 16 forks source link

fix: session data shape bug #1264

Closed jaredgalanis closed 6 months ago

jaredgalanis commented 6 months ago

Closes: #https://github.com/eclipse-pass/main/issues/974

jaredgalanis commented 6 months ago

The code looks good as well as the test.

But there does seem to be one regression. I'm noticing that the whoami service is getting called on every click.

@markpatton, it was the new setup method that's required after bumping ember-simple-auth that was calling restore every time.

I was not transitioning in my testing because I was running without the backend. The latest change just moves where setup is called until after we have verified that we are not authenticated.