eclipse-pass / pass-ui

UI code base for PASS
Apache License 2.0
4 stars 16 forks source link

Investigate a code path in which a submission title is not captured in the metadata blob but user were able to proceed through the workflow anyways. #692

Closed htpvu closed 6 years ago

cameronblandford commented 6 years ago

I'm guessing there's not any more information about how this happened?

htpvu commented 6 years ago

The only other tidbit of information we have is that the title was found as a file description.

We dont have any other information on how this happen. we just happened to find a failing deposit in the system.

cameronblandford commented 6 years ago

Got it. Will look into this and do what I can to replicate. After an hour or two poking around, I'll try to provide a better estimate.

emetsger commented 6 years ago

@cameronblandford I'm the one who observed the behavior, so if there are any questions, don't hesitate to ask.

The submission failed because the title field wasn't present in the common metadata blob (that is, the field was completely missing, it wasn't present with a null value).

Rytiggy commented 6 years ago

@emetsger was there any other repositories attached to the submission? Do you have the failed submission object available?

emetsger commented 6 years ago

@Rytiggy this is the corrected object (after adding title into the metadata). A copy of the incorrect object isn't available.

Before this object was corrected, the aggregatedDepositStatus was submitted, and title was missing from the metadata blob. The URI of the Submission is https://pass.jhu.edu/fcrepo/rest/submissions/2a/2e/3b/2b/2a2e3b2b-1603-43f9-a2d2-092f62754163

I corrected the object by adding in title, and then re-submitting the Submission to deposit services. The deposit succeeded, and the aggregatedDepositStatus was flipped to accepted.

{
  "@id" : "https://pass.jhu.edu/fcrepo/rest/submissions/2a/2e/3b/2b/2a2e3b2b-1603-43f9-a2d2-092f62754163",
  "@type" : "Submission",
  "aggregatedDepositStatus" : "accepted",
  "metadata" : "[{\"id\":\"JScholarship\",\"data\":{\"embargo\":\"NON-EXCLUSIVE LICENSE FOR USE OF MATERIALS This non-exclusive license defines the terms for the deposit of Materials in all formats into the digital repository of materials collected, preserved and made available through the Johns Hopkins Digital Repository, JScholarship. The Contributor hereby grants to Johns Hopkins a royalty free, non-exclusive worldwide license to use, re-use, display, distribute, transmit, publish, re-publish or copy the Materials, either digitally or in print, or in any other medium, now or hereafter known, for the purpose of including the Materials hereby licensed in the collection of materials in the Johns Hopkins Digital Repository for educational use worldwide. In some cases, access to content may be restricted according to provisions established in negotiation with the copyright holder. This license shall not authorize the commercial use of the Materials by Johns Hopkins or any other person or organization, but such Materials shall be restricted to non-profit educational use. Persons may apply for commercial use by contacting the copyright holder. Copyright and any other intellectual property right in or to the Materials shall not be transferred by this agreement and shall remain with the Contributor, or the Copyright holder if different from the Contributor. Other than this limited license, the Contributor or Copyright holder retains all rights, title, copyright and other interest in the images licensed. If the submission contains material for which the Contributor does not hold copyright, the Contributor represents that s/he has obtained the permission of the Copyright owner to grant Johns Hopkins the rights required by this license, and that such third-party owned material is clearly identified and acknowledged within the text or content of the submission. If the submission is based upon work that has been sponsored or supported by an agency or organization other than Johns Hopkins, the Contributor represents that s/he has fulfilled any right of review or other obligations required by such contract or agreement. Johns Hopkins will not make any alteration, other than as allowed by this license, to your submission. This agreement embodies the entire agreement of the parties. No modification of this agreement shall be of any effect unless it is made in writing and signed by all of the parties to the agreement.\",\"agreement-to-deposit\":\"true\"}},{\"id\":\"common\",\"data\":{\"title\":\"Blood Conservation in Orthopedic Trauma\",\"journal-title\":\"Techniques in Orthopaedics\",\"volume\":\"32\",\"issue\":\"1\",\"ISSN\":\"0885-9698\",\"authors\":[{\"author\":\"Suresh K. Nayar\"},{\"author\":\"Babar Shafiq\"}],\"issn-map\":{\"0885-9698\":{\"pub-type\":[\"Print\"]}}}},{\"id\":\"crossref\",\"data\":{\"doi\":\"10.1097/bto.0000000000000208\",\"publisher\":\"Ovid Technologies (Wolters Kluwer Health)\",\"journal-title-short\":\"Techniques in Orthopaedics\"}},{\"id\":\"pmc\",\"data\":{\"nlmta\":\"Tech Orthop\"}}]",
  "publication" : "https://pass.jhu.edu/fcrepo/rest/publications/6f/0d/84/ad/6f0d84ad-26d3-45cd-90b6-c94b755d546a",
  "repositories" : [ "https://pass.jhu.edu/fcrepo/rest/repositories/41/96/0a/92/41960a92-d3f8-4616-86a6-9e9cadc1a269" ],
  "source" : "pass",
  "submitted" : true,
  "submittedDate" : "2018-07-19T15:20:59.299Z",
  "user" : "https://pass.jhu.edu/fcrepo/rest/users/77/fc/64/92/77fc6492-64a7-4dff-ba9e-07d636b8e6b2",
  "@context" : "https://oa-pass.github.io/pass-data-model/src/main/resources/context-2.2.jsonld"
}
emetsger commented 6 years ago

@Rytiggy the only Repository attached to the submission was:

{
  "@id" : "https://pass.jhu.edu/fcrepo/rest/repositories/41/96/0a/92/41960a92-d3f8-4616-86a6-9e9cadc1a269",
  "@type" : "Repository",
  "formSchema" : "{\"id\":\"JScholarship\",\"schema\":{\"title\":\"Johns Hopkins - JScholarship <br><p class='lead text-muted'>Deposit requirements for JH's institutional repository JScholarship.</p>\",\"type\":\"object\",\"properties\":{\"embargo\":{\"type\":\"string\",\"default\":\"NON-EXCLUSIVE LICENSE FOR USE OF MATERIALS This non-exclusive license defines the terms for the deposit of Materials in all formats into the digital repository of materials collected, preserved and made available through the Johns Hopkins Digital Repository, JScholarship. The Contributor hereby grants to Johns Hopkins a royalty free, non-exclusive worldwide license to use, re-use, display, distribute, transmit, publish, re-publish or copy the Materials, either digitally or in print, or in any other medium, now or hereafter known, for the purpose of including the Materials hereby licensed in the collection of materials in the Johns Hopkins Digital Repository for educational use worldwide. In some cases, access to content may be restricted according to provisions established in negotiation with the copyright holder. This license shall not authorize the commercial use of the Materials by Johns Hopkins or any other person or organization, but such Materials shall be restricted to non-profit educational use. Persons may apply for commercial use by contacting the copyright holder. Copyright and any other intellectual property right in or to the Materials shall not be transferred by this agreement and shall remain with the Contributor, or the Copyright holder if different from the Contributor. Other than this limited license, the Contributor or Copyright holder retains all rights, title, copyright and other interest in the images licensed. If the submission contains material for which the Contributor does not hold copyright, the Contributor represents that s/he has obtained the permission of the Copyright owner to grant Johns Hopkins the rights required by this license, and that such third-party owned material is clearly identified and acknowledged within the text or content of the submission. If the submission is based upon work that has been sponsored or supported by an agency or organization other than Johns Hopkins, the Contributor represents that s/he has fulfilled any right of review or other obligations required by such contract or agreement. Johns Hopkins will not make any alteration, other than as allowed by this license, to your submission. This agreement embodies the entire agreement of the parties. No modification of this agreement shall be of any effect unless it is made in writing and signed by all of the parties to the agreement.\"},\"agreement-to-deposit\":{\"type\":\"string\"}}},\"options\":{\"fields\":{\"embargo\":{\"type\":\"textarea\",\"label\":\"Deposit Agreement\",\"disabled\":true,\"rows\":\"16\"},\"agreement-to-deposit\":{\"type\":\"checkbox\",\"rightLabel\":\"I agree to the above statement on today's date\",\"fieldClass\":\"col-12 text-right p-0\"}}}}",
  "integrationType" : "full",
  "name" : "JScholarship",
  "url" : "https://jscholarship.library.jhu.edu/",
  "@context" : "https://oa-pass.github.io/pass-data-model/src/main/resources/context-2.2.jsonld"
emetsger commented 6 years ago

And, the Publication resource:

{
  "@id" : "https://pass.jhu.edu/fcrepo/rest/publications/6f/0d/84/ad/6f0d84ad-26d3-45cd-90b6-c94b755d546a",
  "@type" : "Publication",
  "doi" : "10.1097/BTO.0000000000000208",
  "issue" : "1",
  "journal" : "https://pass.jhu.edu/fcrepo/rest/journals/b2/81/28/ea/b28128ea-fe9b-4a44-8cfe-33a62625807d",
  "title" : "Blood Conservation in Orthopedic Trauma",
  "volume" : "32",
  "@context" : "https://oa-pass.github.io/pass-data-model/src/main/resources/context-2.2.jsonld"
}