search

eclipse-passage / passage

Define and control license checks and usage constraints for OSGi / RCP / IDE
https://www.eclipse.org/passage/
Eclipse Public License 2.0
7 stars 8 forks source link

Unnecessary API Compatibility check #1233

Closed zelenyhleb closed 1 year ago

zelenyhleb commented 1 year ago

In some bundles we have these lines in .settings:

incompatible_api_component_version_include_major_without_breaking_change=Disabled
incompatible_api_component_version_include_minor_without_api_change=Disabled
incompatible_api_component_version_report_major_without_breaking_change=Error
incompatible_api_component_version_report_minor_without_api_change=Error

Two last entries cause errors for some bundles even after initial project workspace configuration. image

As far as I know, bundle versions in Passage Project are incremented all together, i. e. all bundle versions should be the same for the whole codebase. So, do we really need these checks? My proposal is to disable them as well as the first two entries to have initial project configuration clean. WDYT, @eparovyshnaya @ruspl-afed?

eparovyshnaya commented 1 year ago

Indeed, if we are intended to keep incrementing all versoions simultneousely, we''ll face these errors each time. Vote in favour of disabling the checks. Will need another one though, to ensure all bundle versions are incremented properly.