eclipse-passage / passage

Define and control license checks and usage constraints for OSGi / RCP / IDE
https://www.eclipse.org/passage/
Eclipse Public License 2.0
7 stars 8 forks source link

[#1237] Align target with SimRel 2023-09 #1243

Closed ruspl-afed closed 1 year ago

ruspl-afed commented 1 year ago

Switch to notarized version of JNA

ruspl-afed commented 1 year ago

@merks do I need to do anything else with JNA to align with SimRel?

codecov[bot] commented 1 year ago

Codecov Report

Merging #1243 (cba596a) into master (1d55e62) will not change coverage. The diff coverage is n/a.

:exclamation: Current head cba596a differs from pull request most recent head c010259. Consider uploading reports for the commit c010259 to get more accurate results

@@            Coverage Diff            @@
##             master    #1243   +/-   ##
=========================================
  Coverage     33.48%   33.48%           
  Complexity      359      359           
=========================================
  Files          1175     1175           
  Lines         25744    25744           
  Branches       1590     1590           
=========================================
  Hits           8620     8620           
  Misses        16603    16603           
  Partials        521      521           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

merks commented 1 year ago

@merks do I need to do anything else with JNA to align with SimRel?

The direct from maven version is not currently causing Mac notarization problems but it has in the past. Using the one with signed *.jnilib from https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/milestone/latest would be advisable.

merks commented 1 year ago

Thank you. 😃

merks commented 1 year ago

FYI, you could consider to update your oshi dependency:

https://github.com/eclipse-orbit/orbit-simrel/blob/main/report/maven-osgi/passage/REPORT.md

ruspl-afed commented 1 year ago

Thank you Ed @merks , we will consider this dependency update if new version of oshi will work well for us