search

eclipse-passage / passage

Define and control license checks and usage constraints for OSGi / RCP / IDE
https://www.eclipse.org/passage/
Eclipse Public License 2.0
6 stars 8 forks source link

[FLS] Complete migration to Jetty-12 and consider handlers again #1258

Closed HannesWell closed 6 months ago

HannesWell commented 6 months ago

This completes the migration of Passage's JettyHandler and JettyRequest to Jetty-12,which was started in https://github.com/eclipse-passage/passage/pull/1253, but has left the FLS in a dysfunctional state. This PR completes that migration so that response handlers are considered again to restore the FLS full functionality.

The changes are done with the great help of the Jetty-12 migration guide: https://eclipse.dev/jetty/documentation/jetty-12/programming-guide/index.html#pg-migration-11-to-12-servlet-to-handler

codecov[bot] commented 6 months ago

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (12031b8) 33.45% compared to head (377a387) 33.48%.

Files Patch % Lines
...lipse/passage/lic/internal/jetty/JettyHandler.java 0.00% 15 Missing :warning:
...lipse/passage/lic/internal/jetty/JettyRequest.java 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1258 +/- ## ============================================ + Coverage 33.45% 33.48% +0.02% Complexity 359 359 ============================================ Files 1175 1175 Lines 25763 25743 -20 Branches 1594 1589 -5 ============================================ Hits 8619 8619 + Misses 16623 16603 -20 Partials 521 521 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HannesWell commented 6 months ago

Thank you @eparovyshnaya for the fast review.

I tried to apply all your specific and general remarks. Please let me know if I missed something.

eparovyshnaya commented 6 months ago

@ruspl-afed can we maybe issue a patch-release for this critial bug which is fixed by this PR (many thanks to that @HannesWell)?

HannesWell commented 6 months ago

@ruspl-afed can we maybe issue a patch-release for this critial bug which is fixed by this PR (many thanks to that @HannesWell)?

Your welcome. A patch release would be nice to have. If you have a quickly to implement idea for https://github.com/eclipse-passage/passage/issues/1260 it would be great to include that as well. :)

ruspl-afed commented 6 months ago

@ruspl-afed can we maybe issue a patch-release for this critial bug which is fixed by this PR (many thanks to that @HannesWell)?

Release for Passage 2.10.1 has been planned. Many thanks to @HannesWell for this fix!