eclipse-passage / passage

Define and control license checks and usage constraints for OSGi / RCP / IDE
https://www.eclipse.org/passage/
Eclipse Public License 2.0
6 stars 8 forks source link

Remove generated OSGi Declarative service component files from SCM #1365

Closed HannesWell closed 1 month ago

HannesWell commented 1 month ago

OSGi-DS component XML files are generated in the IDE (by PDE) and while building Passage (with Maven+Tycho) in the CI. Therefore there is no need to maintain the component xml-files in git. It just causes unnecessary duplication on changes in the classes and is also prone to out-of-sync errors like https://github.com/eclipse-passage/passage/issues/1364. I therefore suggest to just remove them from git.

eparovyshnaya commented 1 month ago

Occaionally discussion on this subject happened in #1364, some of the project's concerns are enlisted there. The changes demanded are not to be applied.