Zoo of logging frameworks

eparovyshnaya commented 4 years ago

During the work on 553877 spend some time investigating logging frameworks used in Eclipse Passage. Results are interesting and worth to be discussed.

We use

JUL directly,
OSGi logging in some equinox-based bundles,
SLF4J in a sporadic way,
Jetty logging for JettyServer

How we do this

JUL directly
- all the *Messages.java
- org.eclipse.passage.lbc.internal.equinox.conditions.ServerConditionArbiter
- org.eclipse.passage.lic.internal.equinox.requirements.BundleCapabilityResolver
- org.eclipse.passage.lic.internal.hc.HcConditionMiner
- org.eclipse.passage.loc.internal.licenses.core.LicenseMailSupport
- org.eclipse.passage.loc.workbench.dialogs
OSGi logging
- org.eclipse.passage.lbc.internal.equinox.ServerRunnerImpl
- org.eclipse.passage.lic.internal.equinox.requirements.ComponentConfigurationResolver
SLF4J
- org.eclipse.passage.lbc.internal.equinox.conditions.AcquireConditionActionExecutor
- org.eclipse.passage.lic.hc.HttpRequests
- org.eclipse.passage.loc.internal.workbench.LocDomainRegistryAccess

Findings

One physical package exploits several logging frameworks
Each particular framework does not seem to have a peculiar reason to be used here or there.

Question

Should we put things here in some order?

Suggestion

I think, that, for understandable causes (like, say, logging configuration), there should be

either a static choice (like, JUL)
or some reasonable strategy for choosing a framework. Like:
- OSGi logging for OSGi/Equinox dependent packages
- SLF4J+JUL for the rest of the bundles

What do you think, colleagues?

eparovyshnaya commented 3 years ago

572145 Jetty integration logs through log4j2