search

eclipse-pde / eclipse.pde.build

0 stars 6 forks source link

backport: Use the actual system-packages from the JVM for export #16

Closed gireeshpunathil closed 1 year ago

gireeshpunathil commented 1 year ago

Fixes https://github.com/eclipse-pde/eclipse.pde/issues/194 for PDE-build in 4.23

Refs: https://github.com/eclipse-pde/eclipse.pde/issues/624

/cc @HannesWell

gireeshpunathil commented 1 year ago

surprisingly, ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/TargetPlatformHelper.java is appearing a completely new file in this web interface! is this some sort of a bug? or am I making anything wrong?

HannesWell commented 1 year ago

surprisingly, ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/TargetPlatformHelper.java is appearing a completely new file in this web interface! is this some sort of a bug? or am I making anything wrong?

o.e.pde.core always lived in PDE's 'main' repo and was never in this one. If the backported commit contains changes in that file it has to be done in the other repo on the corresponding maintance branch, if it is not already there.

Probably the best is to have both repos checked out at the R4_23 branch and import the pde.build projects from this repo and then make it work.

vik-chand commented 1 year ago

" > surprisingly, ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/TargetPlatformHelper.java is appearing a

Probably the best is to have both repos checked out at the R4_23 branch and import the pde.build projects from this repo and then make it work. :"

Yes, also knowing that the change is in 1-2 files ( max 3 files) should make this easier

gireeshpunathil commented 1 year ago

But I havn't checked the code, assuming you left it unchanged.

yes, no change in the code except downgrading of org.eclipse.jdt.launching to match the 4.23 prevalence.