search

eclipse-pde / eclipse.pde

Eclipse Public License 2.0
25 stars 64 forks source link

Rely on system-packages of Equinox JRE-1.1 profile #1239

Closed HannesWell closed 5 months ago

HannesWell commented 5 months ago

With https://github.com/eclipse-equinox/equinox/pull/596 the JRE-1.1 profile embedded in Equinox was updated to have the expected system-packages. Therefore the hard-coded ones in PDE can be removed.

See also https://github.com/eclipse-pde/eclipse.pde/issues/1231#issuecomment-2057561119.

github-actions[bot] commented 5 months ago

Test Results

   291 files  +   18     291 suites  +18   53m 30s :stopwatch: + 19m 13s  3 526 tests +2 626   3 468 :white_check_mark: +2 606   58 :zzz: +24  0 :x:  -  4  10 875 runs  +8 109  10 698 :white_check_mark: +8 049  177 :zzz: +72  0 :x:  - 12 

Results for commit cfac6da0. ± Comparison against base commit a404764f.

akurtakov commented 5 months ago

I haven't looked into "why" but since this commit we get https://ci.eclipse.org/pde/job/eclipse.pde/job/master/643/maven-warnings/new/source.ac496625-1c6e-4e5d-9b31-fdbd8eeb12b5/#8143 in master builds.

HannesWell commented 5 months ago

I haven't looked into "why" but since this commit we get https://ci.eclipse.org/pde/job/eclipse.pde/job/master/643/maven-warnings/new/source.ac496625-1c6e-4e5d-9b31-fdbd8eeb12b5/#8143 in master builds.

I tested this before submitting this in a debugged IDE and at least there it worked. I don't know the setup of the DS TCK exactly, could it be the case that there the Equinox system bundle from the latest releases and the latest I-build of PDE or even the one build is mixed in the runtime? IIRC at least Tycho's API tools plugin did something like that, but @laeubi probably knows it better than I do.

laeubi commented 5 months ago

The warnings will only go away after the next release when Tycho has picked up the Equinox change. I don't think this is related to API tools in any way.