Closed jukzi closed 1 day ago
HeikoKlare
commented
4 months ago This might also be related to:
I hope that eclipse-platform/eclipse.platform#1367 fixes eclipse-platform/eclipse.platform#1366, so I would propose to check tomorrow's I-Build to see if this issue may also be fixed by that.
HeikoKlare
commented
4 months ago I tried to find out whether one of those PRs is related to these test failures, but it is quite complicated as only I-Builds seem to be affected:
What I can at least say is that the code that throws an exception in the test case testRemoveFilter() is only executed when the project to be created already existed. This is the case because testAddFilterFromFilter() failed, so most likely the problem is only with the failing teardown of testAddFilterFromFilter(). Fixing that test will also fix the other one.
The stack trace for the failing teardown (doing a deletion of a project) indicates that the workspace is not up to date, as the workspace tree is traversed to delete elements from the leaves to the root, but still the .settings folder is not empty when trying to delete it:
java.nio.file.DirectoryNotEmptyException: /home/jenkins/agent/workspace/AutomatedTests/ep432I-unit-cen64-gtk3-java17/workarea/I20240513-1800/eclipse-testing/test-eclipse/eclipse/api_tools_plugins_folder/data/APIPluginTests/.settings
at java.base/sun.nio.fs.UnixFileSystemProvider.implDelete(UnixFileSystemProvider.java:246)
at java.base/sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(AbstractFileSystemProvider.java:110)
at java.base/java.nio.file.Files.deleteIfExists(Files.java:1191)
at org.eclipse.core.internal.filesystem.local.LocalFile.internalDelete(LocalFile.java:286)
at org.eclipse.core.internal.filesystem.local.LocalFile.delete(LocalFile.java:159)
at org.eclipse.core.internal.localstore.DeleteVisitor.delete(DeleteVisitor.java:66)
at org.eclipse.core.internal.localstore.DeleteVisitor.visit(DeleteVisitor.java:156)
at org.eclipse.core.internal.localstore.UnifiedTree.accept(UnifiedTree.java:119)
at org.eclipse.core.internal.localstore.FileSystemResourceManager.delete(FileSystemResourceManager.java:412)Still the question is why this suddenly popped up. One change in addition to the platform ones at the day before the failure popped up is:
But I don't see how that should be related.
HannesWell
commented
1 day ago The tests are not failing anymore in the latest I-builds so I think we can assume this is fixed somehow.
Both on win and linux but not on Mac: https://download.eclipse.org/eclipse/downloads/drops4/I20240513-1800/testresults/html/org.eclipse.pde.api.tools.tests_ep432I-unit-win32-java17_win32.win32.x86_64_17.html https://download.eclipse.org/eclipse/downloads/drops4/I20240513-1800/testresults/html/org.eclipse.pde.api.tools.tests_ep432I-unit-cen64-gtk3-java17_linux.gtk.x86_64_17.html
Can not reproduce locally, there where no recent commits to PDE.
Popped up at the same time as https://github.com/eclipse-platform/eclipse.platform/issues/1366