search

eclipse-pde / eclipse.pde

Eclipse Public License 2.0
25 stars 64 forks source link

Only schedule a build if manifest builder is enabled for project #1268

Closed laeubi closed 4 months ago

laeubi commented 4 months ago

Currently MinimalState schedules a build for every project that has any PDE nature, this can lead to projects scanned that have no ManifestBuilder enabled at all and creating unrelated warnings.

This now checks if the builder is enabled for the project before scheduling a build. Also the check for possible invalid invocations is moved up so it is triggered even if a build.properties exits.

Fix https://github.com/eclipse-pde/eclipse.pde/issues/1185

github-actions[bot] commented 4 months ago

Test Results

   291 files  ±0     291 suites  ±0   56m 16s :stopwatch: + 1m 54s  3 526 tests ±0   3 468 :white_check_mark: ±0   58 :zzz: ±0  0 :x: ±0  10 875 runs  ±0  10 698 :white_check_mark: ±0  177 :zzz: ±0  0 :x: ±0 

Results for commit 394ad871. ± Comparison against base commit 2afa4d37.

:recycle: This comment has been updated with latest results.