search

eclipse-pde / eclipse.pde

Eclipse Public License 2.0
25 stars 64 forks source link

[PDE-Build] Always use the OSGi profiles provided by the runtime bundle #1270

Closed HannesWell closed 4 months ago

HannesWell commented 4 months ago

The code in PDE(-build) usually only matches respectively is adapted to content of the profiles provided by the org.eclipse.osgi bundle of the same release and not necessarily of previous or even future releases. For example with https://github.com/eclipse-pde/eclipse.pde/pull/1239 PDE-build now relies on the system.packages provided by the JRE-1.1 profile in o.e.osgi since this release. Of course these profiles are missing in previous versions of o.e.osgi. This causes errors during PDE's product export if an earlier version of o.e.osgi is in the target-platform because the system.packages for the JRE-1.1 are then null/empty.

github-actions[bot] commented 4 months ago

Test Results

  204 files   -    87    204 suites   - 87   35m 8s :stopwatch: - 23m 25s 3 526 tests ±    0  3 466 :white_check_mark:  -     2  60 :zzz: + 2  0 :x: ±0  7 132 runs   - 3 743  7 042 :white_check_mark:  - 3 656  90 :zzz:  - 87  0 :x: ±0 

Results for commit a36feba8. ± Comparison against base commit c2d4b0c1.

This pull request skips 2 tests. ``` org.eclipse.pde.build.internal.tests.ScriptGenerationTests ‑ testBug238177 org.eclipse.pde.build.internal.tests.p2.P2Tests ‑ offBug237662 ```
HannesWell commented 4 months ago

API-tools failures in Windows/Mac GH workflows seem unrelated.