search

eclipse-pde / eclipse.pde

Eclipse Public License 2.0
24 stars 58 forks source link

Wrong property fired in Product#setIncludeJre #1278

Closed Phillipus closed 4 weeks ago

Phillipus commented 4 weeks ago

The property P_INCLUDE_LAUNCHERS is fired here:

https://github.com/eclipse-pde/eclipse.pde/blob/96484560b85cf472802badf93bd4555a3e881641/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/product/Product.java#L899-L906

It should be P_INCLUDE_JRE

Phillipus commented 4 weeks ago

PR https://github.com/eclipse-pde/eclipse.pde/pull/1279