search

eclipse-pde / eclipse.pde

Eclipse Public License 2.0
24 stars 58 forks source link

Fire the correct property in Product#setIncludeJre #1279

Closed Phillipus closed 4 weeks ago

Phillipus commented 4 weeks ago

The property should be P_INCLUDE_JRE not P_INCLUDE_LAUNCHERS

Fixes https://github.com/eclipse-pde/eclipse.pde/issues/1278

github-actions[bot] commented 4 weeks ago

Test Results

  206 files  ±0    206 suites  ±0   34m 28s :stopwatch: -24s 3 578 tests ±0  3 502 :white_check_mark: ±0   76 :zzz: ±0  0 :x: ±0  7 402 runs  ±0  7 248 :white_check_mark: ±0  154 :zzz: ±0  0 :x: ±0 

Results for commit 5871126d. ± Comparison against base commit 96484560.

HannesWell commented 4 weeks ago

Actually we already have RC2 promotion today with the I-build from yesterday. So unless there is a RC2a for the SDK, this will fix will not be in Eclipse 2024-06. But I think that's not a blocker that alone justifies a RC2a.

merks commented 4 weeks ago

I'm not sure we should be committing changes before master is open again....

akurtakov commented 4 weeks ago

@HannesWell For the future please don't push changes at that state of the cycle.