search

eclipse-pde / eclipse.pde

Eclipse Public License 2.0
24 stars 58 forks source link

Track whether the manifest of a bundle component has an explicit EE #1292

Closed merks closed 3 weeks ago

merks commented 3 weeks ago

https://github.com/eclipse-pde/eclipse.pde/issues/1283

merks commented 3 weeks ago

@iloveeclipse

I've verified that this fixed the problem where the baseline version and the workspace version as the same and now both are validated such that both indicate they have no BREE and hence to BREE change:

image

Also verified that if I were to add an explicit BREE, this would be detected as a change to the BREE:

image

github-actions[bot] commented 3 weeks ago

Test Results

  285 files   -     6    285 suites   - 6   48m 40s :stopwatch: - 12m 4s 3 578 tests ±    0  3 500 :white_check_mark:  -     2   76 :zzz: ± 0  1 :x: +1  1 :fire: +1  8 328 runs   - 2 703  8 119 :white_check_mark:  - 2 681  207 :zzz:  - 24  1 :x: +1  1 :fire: +1 

For more details on these failures and errors, see this check.

Results for commit a41eb46b. ± Comparison against base commit 8e177eef.

merks commented 3 weeks ago

@iloveeclipse

I'll give some more time to review, but I'd like to commit this today so that I can update my IDE to fix the problem tomorrow....

iloveeclipse commented 3 weeks ago

I'll give some more time to review, but I'd like to commit this today so that I can update my IDE to fix the problem tomorrow....

Sure. I've checked the patch on Linux, sounds reasonable, but I'm not that deep in this PDE code. I would say we should merge to get rid of the current (false positive) error on SWT and if the patch could be improved, it should be improved later.