Test removing org.eclipse.rcp.configuration.feature.group

eclipse-pde / eclipse.pde

Eclipse Public License 2.0

24 stars 58 forks source link

Test removing org.eclipse.rcp.configuration.feature.group #1293

Closed merks closed 2 weeks ago

merks commented 3 weeks ago

https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/issues/2109

github-actions[bot] commented 3 weeks ago

Test Results

289 files + 85 289 suites +85 58m 38s :stopwatch: + 26m 9s 3 578 tests ± 0 3 501 :white_check_mark: + 1 77 :zzz: - 1 0 :x: ±0 10 865 runs +3 629 10 662 :white_check_mark: +3 552 203 :zzz: +77 0 :x: ±0

Results for commit c1b58d6f. ± Comparison against base commit b0dc38ab.

:recycle: This comment has been updated with latest results.

merks commented 2 weeks ago

@laeubi

Surprisingly it seems all the tests pass!

@HannesWell

The failures look like build/infrastructure problems, not test failures...

laeubi commented 2 weeks ago

Just be aware that removing it from test.xml will not be validated in a PR but at least for maven it looks like it works...

merks commented 2 weeks ago

I see. Sort of but not really. I see it referenced here:

So I assumed that tests just use it.

What else uses this and when/where?

This suggested there is no way to know without changing it and hoping for the best. 😨

laeubi commented 2 weeks ago

It is used by the I-Build: https://wiki.eclipse.org/Platform-releng/Eclipse_Test_Framework

the referenced one in code might or might not be taht test.xml as there are many of them...

merks commented 2 weeks ago

@iloveeclipse @akurtakov @MohananRahul

FYI, this change has some chance to break the I-Build via the PDE Build Test so I thought I'd give you a heads up...

akurtakov commented 2 weeks ago

Please start extra I build to test it.

merks commented 2 weeks ago

I've started https://ci.eclipse.org/releng/job/Builds/job/I-build-4.33/13/

merks commented 2 weeks ago

The build finished and I think it launched these tests:

But my knowledge of how this part works is poor. 😢

I think it's the stuff running on this page that I need to monitor:

https://ci.eclipse.org/releng/job/AutomatedTests/

merks commented 2 weeks ago

If I'm reading the tea leaves correctly, only this JDT test is failing:

So am I safe to assume this change caused neither build nor test regressions? Then I can proceed to remove what has no become an unused feature...

iloveeclipse commented 2 weeks ago

Yes, if you mean these tests: https://download.eclipse.org/eclipse/downloads/drops4/I20240611-0150/testResults.php I don't see "unexpected" new failures.

merks commented 2 weeks ago

@iloveeclipse

Thanks for confirming! That's very good news! 🎉