search

eclipse-pde / eclipse.pde

Eclipse Public License 2.0
24 stars 58 forks source link

New entries for Import-Package get a version range which breaks semantic versioning #1297

Closed mwgmnn closed 2 weeks ago

mwgmnn commented 2 weeks ago

This is a result of issue #401, which solves more that was initially asked (strip micro version). It's ok from my point of view to add an upper version limit. But i suggest to exclude the next major version by replacing the ] by a ) in the returning version range to properly follow semantic versioning.

laeubi commented 2 weeks ago

@mwgmnn what version do you use? I think this was already fixed by @HannesWell recently.

mwgmnn commented 2 weeks ago

@mwgmnn what version do you use? I think this was already fixed by @HannesWell recently.

It's Version 2024-03 (4.31.0), Build id: 20240307-1437.

Ok, sorry, i missed the pull request #1007. The actual code looks fine, so looking forward to the next eclipse version release.

https://github.com/eclipse-pde/eclipse.pde/blob/master/ui/org.eclipse.pde.core/text/org/eclipse/pde/internal/core/text/bundle/ImportPackageObject.java

merks commented 2 weeks ago

FYI, the 2024-06 / 4.32 release is now available.

mwgmnn commented 2 weeks ago

Yes, great timing, thanks a lot.

HannesWell commented 2 weeks ago

@mwgmnn what version do you use? I think this was already fixed by @HannesWell recently.

All said is correct, but for the record: This was fixed with https://github.com/eclipse-pde/eclipse.pde/pull/1212.