search

eclipse-pde / eclipse.pde

Eclipse Public License 2.0
25 stars 64 forks source link

Remove old 1.x Java compiler versions support from PDE tests #1309

Closed iloveeclipse closed 3 months ago

iloveeclipse commented 3 months ago

Basically moves tests that used various old 1.x JDK compiler settings to use 1.8 target (only supported 1.x Java compiler target in the future).

See https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2536

github-actions[bot] commented 3 months ago

Test Results

   291 files  ±0     291 suites  ±0   58m 20s :stopwatch: -7s  3 578 tests ±0   3 502 :white_check_mark: ±0   76 :zzz: ±0  0 :x: ±0  11 031 runs  ±0  10 800 :white_check_mark: ±0  231 :zzz: ±0  0 :x: ±0 

Results for commit b28de3dd. ± Comparison against base commit c32168e4.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. ``` AllPDETests org.eclipse.pde.ui.tests.wizards.AllNewProjectTests org.eclipse.pde.ui.tests.ee.ExecutionEnvironmentTests ‑ testJava4Environment ``` ``` AllPDETests org.eclipse.pde.ui.tests.wizards.AllNewProjectTests org.eclipse.pde.ui.tests.ee.ExecutionEnvironmentTests ‑ testJava8Environment ```

:recycle: This comment has been updated with latest results.

iloveeclipse commented 3 months ago

@HannesWell : any objections ?

HannesWell commented 3 months ago

@HannesWell : any objections ?

No objections, please go ahead. Thanks for being proactive.

But please address Lars requests for changes, even if technically not absolutely necessary.