Bypass API analysis for classes from a test classpath entry

eclipse-pde / eclipse.pde

Eclipse Public License 2.0

24 stars 58 forks source link

Bypass API analysis for classes from a test classpath entry #1313

Closed merks closed 3 days ago

merks commented 3 days ago

https://github.com/eclipse-platform/eclipse.platform.swt/issues/1298

github-actions[bot] commented 3 days ago

Test Results

291 files + 2 291 suites +2 55m 17s :stopwatch: - 7m 25s 3 578 tests ± 0 3 502 :white_check_mark: + 1 76 :zzz: - 1 0 :x: ±0 11 031 runs +166 10 800 :white_check_mark: +138 231 :zzz: +28 0 :x: ±0

Results for commit a69e8224. ± Comparison against base commit a5391bd6.

HannesWell commented 2 days ago

In a (private) chat with Ed I understood this as a 'last' resort solution but since we got https://github.com/eclipse-platform/eclipse.platform.swt/pull/1305 this is not necessary anymore to fix the underlying issue. So should we still keep this? If yes, maybe we should move the check to a higher level and let the analyzer just skip test source folders. Then it does not have to be checked again and again when creating problems (which are not always errors).

merks commented 2 days ago

I didn’t merge it. I’m not sure we really need this given swt solved the problem without this.

laeubi commented 2 days ago

I’m not sure we really need this given swt solved the problem without this.

Well SWT not really "solved" this, they installed a workaround (making thing package private) wile this works in this case I still believe test code should not be API checked, if it can happen on a higher level why not.