search

eclipse-pde / eclipse.pde

Eclipse Public License 2.0
28 stars 79 forks source link

Return List<String> in IApiComponent.getExecutionEnvironments() #1396

Closed HannesWell closed 2 months ago

github-actions[bot] commented 2 months ago

Test Results

   285 files  ±0     285 suites  ±0   51m 53s :stopwatch: + 2m 39s  3 581 tests ±0   3 505 :white_check_mark: ±0   76 :zzz: ±0  0 :x: ±0  10 935 runs  ±0  10 704 :white_check_mark: ±0  231 :zzz: ±0  0 :x: ±0 

Results for commit 6ef5c7da. ± Comparison against base commit 951532e9.

:recycle: This comment has been updated with latest results.

jukzi commented 2 months ago

this commit made all tycho builds fail: https://github.com/eclipse-tycho/tycho/issues/4221

HeikoKlare commented 2 months ago

Also makes SWT tests fail, e.g., https://github.com/eclipse-platform/eclipse.platform.swt/actions/runs/10770510714/job/29864024982?pr=1456

laeubi commented 2 months ago

I suggest not to use ibuilds for the API tools check:

HannesWell commented 2 months ago

I suggest not to use ibuilds for the API tools check:

* [Don't use API-Tools from I-Builds for API checks in verification builds eclipse-platform/eclipse.platform.releng.aggregator#2327](https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/2327)

I agree. To add some more context: The changed method is from a 'provisional' API of API-Tools that is still internal. But because there is no stable public API yet Tycho has to use that for the API-Check mojo. This is per-se not a big issue besides that in case something is changed the Tycho mojo has to be adapted but since the same people are involved in both projects the knowledge is usually there. The big problem is that the mojo is/was configured to use the latest API-tools jars from the I-builds. And that introduced a very tight dependency cycle without room to react to changes. So I think the change linked above is the right solution to this problem.