search

eclipse-pde / eclipse.pde

Eclipse Public License 2.0
25 stars 63 forks source link

Support `jars.extra.classpath` in the Manifest editory to avoid confusion with `additional.bundles` #1407

Open laeubi opened 4 days ago

laeubi commented 4 days ago

Currently there is no UI support for jars.extra.classpath in the Manifest editor and du to its prominent placing people instead use often additional.bundles to add something that should be there for compile but not imported (what serves a different purpose) leading to confusion.

Even though jars.extra.classpath theoretically supports different styles, we should only support the form where one can specify a single bundle platform:/plugin/<Bundle-SymbolicName> as this is also supported by Tycho and easy to adapt by other tools.

merks commented 4 days ago

This is a good idea.

I'm not suggesting one needs to make things more complicated so this is just an FYI...

The scheme generally supports

platform:/plugins/<bsn>_<version>/

as parsed by org.eclipse.core.internal.boot.PlatformURLConnection.parse(String).

laeubi commented 4 days ago

The scheme generally supports

Officially also relative path is supported as well as inner jars:

extra classpaths used to perform automated build. Classpath can either be relative paths, or platform urls referring to plug-ins and fragments of your development environment (e.g. ../someplugin/xyz.jar, platform:/plugins/org.apache.ant/ant.jar). Platform urls are recommended over relative paths;

I just think that if one really requires a version or relative path one can do it manually, but e.g additional bundles do only support a BSN and people seem happy with that already (but using it for a different purpose).

merks commented 4 days ago

I 100% agree to keep this simple for the common case!