search

eclipse-pde / eclipse.pde

Eclipse Public License 2.0
25 stars 64 forks source link

NPE in VersionUtil #1410

Closed Bananeweizen closed 1 week ago

Bananeweizen commented 1 week ago

Take same strategy as for a version string: Don't report an error for null values, assuming this just means absence of a version range.

java.lang.NullPointerException: Cannot invoke "String.length()" because "str" is null at java.base/java.util.StringTokenizer.(StringTokenizer.java:199) at org.osgi.framework.VersionRange.(VersionRange.java:137) at org.eclipse.pde.internal.core.util.VersionUtil.validateVersionRange(VersionUtil.java:45) at org.eclipse.pde.internal.core.builders.BundleErrorReporter.validateFragmentHost(BundleErrorReporter.java:480) at org.eclipse.pde.internal.core.builders.BundleErrorReporter.validate(BundleErrorReporter.java:164) at org.eclipse.pde.internal.core.builders.ErrorReporter.validateContent(ErrorReporter.java:109) at org.eclipse.pde.internal.core.builders.ManifestConsistencyChecker.validateManifestFile(ManifestConsistencyChecker.java:318) at org.eclipse.pde.internal.core.builders.ManifestConsistencyChecker.validateProject(ManifestConsistencyChecker.java:272) at org.eclipse.pde.internal.core.builders.ManifestConsistencyChecker.build(ManifestConsistencyChecker.java:194) at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:1077) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:296) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:352) at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:441) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47) at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:444) at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:555) at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:503) at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:585) at org.eclipse.core.internal.resources.Workspace.buildInternal(Workspace.java:595) at org.eclipse.core.internal.resources.Workspace.build(Workspace.java:484) at org.eclipse.oomph.setup.internal.core.SetupTaskPerformer$6.run(SetupTaskPerformer.java:3909) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

github-actions[bot] commented 1 week ago

Test Results

  190 files   -    95    190 suites   - 95   35m 45s :stopwatch: - 23m 1s 3 581 tests ±    0  3 505 :white_check_mark: ±    0   76 :zzz: ± 0  0 :x: ±0  7 290 runs   - 3 645  7 137 :white_check_mark:  - 3 567  153 :zzz:  - 78  0 :x: ±0 

Results for commit b6317941. ± Comparison against base commit b00c27d7.

merks commented 1 week ago

It looks like the only issues are are related to Tycho 4.0.9

Bananeweizen commented 1 week ago

Thanks @merks for clarification. I had a similar thought but wasn't sure enough to go ahead.