eclipse-pde / eclipse.pde

Eclipse Public License 2.0
28 stars 74 forks source link

Plug-in JUnit Launch does not detec Junit5 tests #390

Closed Pontesegger closed 1 month ago

Pontesegger commented 1 year ago

Beginning from 2022-09 I am not able to execute JUnit Plug-in Tests. Works fine with 2022-06 IDE.

My Setup:

When installing an IDE 2022-06 I have a context menu Run As -> JUnit Plug-in Test. Further tests execute fine and results are displayed in the JUnit view.

Now I switched to an IDE 2022-09, keeping the rest of my setup above.

Finding 1) the context menu entry Run As -> JUnit Plug-in Test is gone. To make it reappear I have to add following dependencies to my fragment: org.junit.platform.commons;bundle-version="1.8.1", org.junit.platform.engine;bundle-version="1.8.1", org.junit.jupiter.engine;bundle-version="5.8.1"

Finding 2) With the context menu back I can launch Unit tests, but after execution the JUnit view shows 0 tests. Trying to run with coverage reveals that the test code is actually not executed.

Followed it down to RemoteTestRunner.java#516 The count returned is always 0, so test discovery somehow does not work.

mickaelistria commented 1 year ago

This indeed seems like a bug. Platform adopted upstream junit- bundles in last release instead of Orbit's variant org.junit.. PDE was supposed to work with both equally, but it looks like this doesn't work as well as expected. I would recommend that -if you use a recent IDE and a recent Tycho- you simply stop using org.junit bundles and instead use junit- ones. PDE and Tycho would be happy with it.

Pontesegger commented 1 year ago

Does eclipse then ship junit.* plugins? At least 2022-06 does not seem to have such plug-ins. So which kind of dependencies do you declare for IDE/tycho? Any examples?

akurtakov commented 1 year ago

Is this still an issue?

HannesWell commented 1 month ago

Duplicate of #650