Closed basilevs closed 11 months ago
No IDE at hand right now, but I assume replacing sync with async exec below would fix that without functional problems for the editoe
org.eclipse.swt.widgets.Display.syncExec(Display.java:5250)
@basilevs can you test https://github.com/eclipse-pde/eclipse.pde/pull/921?
@basilevs can you test #921?
Sorry, I can't reproduce the original problem - there seems to be some kind of timing involved.
Still, please try the patch and see if you see ANY issues with it. If not, I plan to merge early next release.
try the patch
OK, how do I install it with Oomph? Or failing that, how do I get the prebuilt package? I can't find any relevant artifacts for PR builds.
There's this if that's what you're asking:
There's this if that's what you're asking: https://github.com/eclipse-pde/.github/blob/main/CONTRIBUTING.md#create-an-eclipse-development-environment
That's development environment. How would I test Oomph target definition in a patch with it? I guess I can start a PDE instance from sources, but how to configure it with Oomph? Or how to populate it with all the stuff Oomph does?
Sorry, yes, the PR builds don't produce an update site that you can test...
I've tried to open "Shared" target definition in a PDE started from sources and it shows empty repository tree. Looks like default launch configuration is missing some relevant plugins.
Should be easy to reproduce.
at org.eclipse.pde.internal.ui.editor.product.ProductInfoSection.stateChanged(ProductInfoSection.java:430)
at org.eclipse.jdt.internal.ui.javaeditor.breadcrumb.BreadcrumbViewer.inputChanged(BreadcrumbViewer.java:275)
Reproduced on master.
@vogella I confirm the fix helps when testing with debugger as per steps by @iloveeclipse
@basilevs : thanks for trying out. I simply have no time to do that. @vogella : I've commented on PR, I believe if we fix one occurrence of bad pattern, we should also fix another one.
@basilevs thanks for verifying @iloveeclipse thanks for the review -> updated with your suggestion
Environment: Eclipse SDK Version: 2023-12 (4.30) Build id: I20231027-1800 OS: Mac OS X, v.12.7, aarch64 / cocoa Java vendor: Oracle Corporation Java runtime version: 17.0.4.1+1-LTS-2 Java version: 17.0.4.1
To reproduce
Deadlock traces: