eclipse-pdt / pdt

PHP Development Tools project (PDT)
https://eclipse.org/pdt
Eclipse Public License 2.0
188 stars 46 forks source link

Missing error on adding default value on variadic param #194

Open the-liquid-metal opened 1 year ago

the-liquid-metal commented 1 year ago

Bug Description Missing error on adding default value on variadic param.

Eclipse environment Version: 2023-06 (4.28.0) Build id: 20230608-1333 PDT: 8.0.0.202306050832

System

To Reproduce Steps to reproduce the behavior: copy-paste this script to the IDE

<?php
declare(strict_types=1);

namespace ns1\ns2;

class Test18 {
    public function fn1(
        int $par1,
        int $par2,
        int ...$par3 = 10, // this statement must trigger error
    ) {}
}

trait Test18b {
    public function fn1(
        int $par1,
        int $par2,
        int ...$par3 = 10, // this statement must trigger error
    ) {}
}

function fn1(
    int $par1,
    int $par2,
    int ...$par3 = 10, // this statement must trigger error
) {}

$var1 = function(
    int $par1,
    int $par2,
    int ...$par3 = 10, // this statement must trigger error
) {};

$var2 = fn(
    int $par1,
    int $par2,
    int ...$par3 = 10, // this statement must trigger error
) => 10;

var_dump($var1, $var2);