search

eclipse-platform / .github

Common contribution content for eclipse-platform repositories
https://www.eclipse.org/eclipse/
5 stars 10 forks source link

Oomph tries to install and use java 19 for java 17 #114

Closed jukzi closed 1 year ago

jukzi commented 1 year ago

As far as i know eclipse won't run arbitrary high java versions (if jdk removes deprecated things). however when i try to install Platform with oomp installer on a computer where it does not find java 17 (but 19) it will try to use 19: image

after selecting 17 image i get asked in the next page where my 17 jdk is. And it again preselects19, but does not offer the already selected 17: image

Bananeweizen commented 1 year ago

I believe you are confusing some things.

The first JRE is the one running eclipse, i.e. the one referenced in the eclipse.ini vm argument. And its default is probably driven by the PATH or "used during last invocation".

On the variables page on the other hand you are asked for the JRE mapping being used for compilation (corresponding to Window>Prefs>Java>JRE Mappings). And that variable (or Java level) is specific to the setup you selected.

merks commented 1 year ago

Eclipse's run option https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fruntime-options.html specify this:

osgi.requiredJavaVersion The minimum java version that is required to launch Eclipse. The default value is "1.4.1".

Also all the BREEs in the bundles specify a minimum.

Nothing specifies an upper bound. So as I know, there is no way know that something won't run on some arbitrary higher version, and I have tested with Java 21 and that works fine.