Compiler warnings not shown

[jukzi]

When creating a PR a jenkins jobs runs that checks for compiler warnings. But all of them are shown empty. example: https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-986/2/java/fileName.-320603757/source.26df7935-bc10-47b7-b2f9-be5c4e44dee4/#7

in the logfile https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-986/2/consoleText one could find there is error message in the next liness. for example:

11:28:16.247 [WARNING] /home/jenkins/agent/workspace/eclipse.platform.ui_PR-986/tools/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/properties/ProjectOSGiTranslationProvider.java:[7] 
    import java.security.AccessController;
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The type AccessController has been deprecated since version 17 and marked for removal

The same effect is visible in the pull request which shows empty annotations:

[Bananeweizen]

things to check would be:

• upgrade the warnings-ng plugin
• try the eclipse() tool instead of the java() tool
• check if any settings of the linux agents might lead to adding artificial linebreaks to the VNC console (I have no idea if something like that is possible)

[jukzi]

experiment in: https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/996 need to use:

• eclipse() instead of java() in Jenkinsfile https://github.com/jenkinsci/warnings-ng-plugin/blob/main/SUPPORTED-FORMATS.md
• ecj need to be configured to produce warnings (at best same as in workspace) in pom.xml https://tycho.eclipseprojects.io/doc/latest/tycho-compiler-plugin/compile-mojo.html#useProjectSettings

  <build>
      <plugins>
          <plugin>
              <groupId>org.eclipse.tycho</groupId>
              <artifactId>tycho-compiler-plugin</artifactId>
              <configuration>
                  <useProjectSettings>true</useProjectSettings>
              </configuration>
          </plugin>
      </plugins>
  </build>

• qualtity gate can be enabled in Jenkinsfile: https://github.com/jenkinsci/warnings-ng-plugin/blob/main/doc/Documentation.md#quality-gate-configuration

recordIssues tools: [eclipse(), mavenConsole(), javaDoc()], qualityGates: [[threshold: 1, type: 'DELTA', unstable: true]]

• do not fail build on warnings. i.e. use -Dmaven.compiler.failOnWarning=false in Jenkinsfile

[akurtakov]

Do you consider this one done?

[jukzi]

done.