search

eclipse-platform / .github

Common contribution content for eclipse-platform repositories
https://www.eclipse.org/eclipse/
5 stars 10 forks source link

First Impressions #2

Closed merks closed 2 years ago

merks commented 2 years ago

If you look at our new organization page, what's your first impression?

https://github.com/eclipse-platform/

Cool slash screen?!

But then you see this:

image

And, at least for me, I think wow, how retro is that?

Maybe it would be better if we showed something that appears more modern, and maybe even something that demonstrates theming, like this:

image

What do you think?

laeubi commented 2 years ago

Honestly I would simply remove the screenshot at all and link to the download packages (and probably other sites where one can get eclipse based projects) as one screenshot can't really express much. Beside that, I don't think that the "dark theme" looks much more modern...

mickaelistria commented 2 years ago

The image is taken fron help content. It'd be nice to upgrade it in help and this .github would be improved without change

merks commented 2 years ago

It would indeed be nice, but it's a huge task to fix all the following imagines (and probably many, many more others):

https://github.com/eclipse-platform/eclipse.platform.common/tree/master/bundles/org.eclipse.platform.doc.isv/guide/images/

I'm not sure anyone plans to do that...

So, failing that daunting task, what should we do?

vogella commented 2 years ago

I can update the image in the help. Searching now for it.

vogella commented 2 years ago

It would indeed be nice, but it's a huge task to fix all the following imagines (and probably many, many more others):

https://github.com/eclipse-platform/eclipse.platform.common/tree/master/bundles/org.eclipse.platform.doc.isv/guide/images/

I'm not sure anyone plans to do that...

Matthias Becker from SAP did a huge update of these images already and AFAIK is still interested in this topic. So in case you see outdated screenshots, please open an issue an cc him

vogella commented 2 years ago

Screenshot updated, closing

merks commented 2 years ago

This scares me. Did you look at how this looks in the documentation? All the images will be like the one on this page, except for one dark theme image that doesn't show project content like in all other images?

https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fguide%2Fint_eclipse.htm&cp%3D2_0_0_2

I think it's more import that the documentation remain cohesive than that we reuse an image from it on the organization page. :-(

merks commented 2 years ago

@vogella

I would really strongly suggest you revert your inappropriate change to the documentation.

vogella commented 2 years ago

@vogella

I would really strongly suggest you revert your inappropriate change to the documentation.

Lets see if I can improve it. Most the starter screenshots look outdated.

merks commented 2 years ago

Yes, it's totally outdated, but if they're going to be updated, they should show the same content as before and be a consistent set of images across that set of documentation. I don't think it's an important goal here to share the image from the documentation. Your image looks bad, e.g., the overflow of the toolbar button in the upper left view...

Why does the sharing even matter when, you can just paste an image and there will be a link, e.g.,

https://user-images.githubusercontent.com/208716/163329507-4508f5aa-76b0-4f9a-aaab-f35a3831c469.png

I assume that link must be permanent. Or not?

Why is sharing important?

vogella commented 2 years ago

@merks like I said, I'm improving the change at the moment ...

vogella commented 2 years ago

https://github.com/eclipse-platform/eclipse.platform.common/pull/5/files

merks commented 2 years ago

That looks better now! It would have been even better if the toolbar didn't overflow onto a new line:

image

Thanks.

rolfth commented 2 years ago

My browser has 'advanced tracking protection' on by default. This hides these images all together: image

vogella commented 2 years ago

That looks better now! It would have been even better if the toolbar didn't overflow onto a new line: Thanks. Done with https://github.com/eclipse-platform/eclipse.platform.common/pull/8