search

eclipse-platform / .github

Common contribution content for eclipse-platform repositories
https://www.eclipse.org/eclipse/
5 stars 10 forks source link

project explorer: make Esc key close the tree view window #38

Open ronso0 opened 2 years ago

ronso0 commented 2 years ago

To close the project explorer view (edit after opeing it as popup from miniized state) currently I have to resort to mouse/touchpad and click anywhere outside the popup. Mapping the Esc key would greatly improve the keyboard workflow IMO

Edit just noticed this applies to all views that open as popup from the minimized state.

vogella commented 2 years ago

The project explorer is not a popup. What do you mean?

image

ronso0 commented 2 years ago

It is if you minimized it to the toolbars row (idk the correct terms for this part of the GUI), then clicking the Explorer icon opens a popup: image

howlger commented 2 years ago

I cannot reproduce this on Windows 10: ESC closes the minimized pop-over Project Explorer view for me.

For example, in a maximized editor, hitting Alt+Shift+W (for Show In) and choosing Project Explorer, opens and transfers the focus to Project Explorer view as pop-over and hitting ESC closes the Project Explorer again and sets the focus back into the maximized editor.

ronso0 commented 2 years ago

What a pity, so it's dependant on platform or window manager? No matter how I open the project explorer it has keyboard focus, though Esc will not close it.

howlger commented 2 years ago

About which platform are you talking?

Can you reproduce the exact steps as described in my previous comment in the Eclipse SDK 4.25RC2 with a fresh workspace?

What happens when you hit Alt+← instead of ESC?

ronso0 commented 2 years ago

About which platform are you talking?

I mean "operating system". Just downloaded that 4.25RC2 but have no idea when I can test that (will need to check what I should backup to keep my working Eclipse setup).

FWIW in my 4.24 setup Alt+← would close the explorer popup but it would also switch to the editor which is left of the current one. So this is no alternative.

howlger commented 2 years ago

I mean "operating system".

I cannot reproduce it on Windows 10. Which operating system do you have?

Just downloaded that 4.25RC2 but have no idea when I can test that (will need to check what I should backup to keep my working Eclipse setup).

Run the Eclipse SDK 4.25RC2 with Java 17 and an empty or not yet existing directory as workspace (-data <workspace_dir>).

FWIW in my 4.24 setup Alt+← would close the explorer popup but it would also switch to the editor which is left of the current one. So this is no alternative.

I see. So two keystrokes are required as a workaround here, Alt+← followed by Alt+→.

ronso0 commented 2 years ago

I cannot reproduce it on Windows 10. Which operating system do you have?

I'm on Ubuntu 20.04 with xfce. I can close any other app's popups with Esc.

ronso0 commented 2 years ago

Just downloaded that 4.25RC2 but have no idea when I can test that (will need to check what I should backup to keep my working Eclipse setup).

Run the Eclipse SDK 4.25RC2 with Java 17 and an empty or not yet existing directory as workspace (-data <workspace_dir>).

That's it, no other (global) Eclipse config files?

ronso0 commented 1 year ago

issue also occurs with Eclipse SDK 4.25RC2

jukzi commented 6 months ago

If you want this to happen please provide a PR otherwise its unlikely to be solved.