eclipse-platform / .github

Common contribution content for eclipse-platform repositories
https://www.eclipse.org/eclipse/
5 stars 10 forks source link

Update Tycho extenstion to 2.7.2 #8

Closed akurtakov closed 2 years ago

akurtakov commented 2 years ago

Dependabot handles updates of regular poms but not in .mvn/extensions.xml.

laeubi commented 2 years ago

According to the dependabot source it should do also handle extensions.xml, so maybe a bug or simply dependabot is lazy here :-)

akurtakov commented 2 years ago

Dependabot chokes on pomless builds thus the config is to run on eclipse-platform-parent only (https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/master/.github/dependabot.yml). There are also no config in the separate repositories where .mvn/extensions.xml, honestly I haven't tried configuring dependabot for extensions.xml in all repos - never found the time to try whether it can check it only in order to ignore the pomless failure.

akurtakov commented 2 years ago

I just pushed https://github.com/akurtakov/eclipse.platform.releng.aggregator/commit/f52e7bab06df3a97fd662dc75f459737d505e7f7 to try whether handling .mvn would work but it doesn't look so.

akurtakov commented 2 years ago

This one is done.

iloveeclipse commented 2 years ago

@akurtakov : just stumbled over this while looking on fd leak in tycho. I don't see file .mvn/extensions.xml in SWT repo. Is this on purpose? What does this tycho extensions thing do?

akurtakov commented 2 years ago

@akurtakov : just stumbled over this while looking on fd leak in tycho. I don't see file .mvn/extensions.xml in SWT repo. Is this on purpose? What does this tycho extensions thing do?

.mvn/extensions.xml is only needed then there are pomless builds. Due to the complicated manner of swt bundles and limited number of them there is no win if we go pomless - thus no such file.

laeubi commented 2 years ago

This would be required to compile SWT pomless (or more specific: antless as a first step) as currently the compile is performed by ant scripts invoked by maven: